wms icon indicating copy to clipboard operation
wms copied to clipboard

[16.0][IMP] stock_release_channel: add smart buttons on stock_release_channel form view

Open victorvermot opened this issue 1 year ago • 6 comments

Result: 9999

victorvermot avatar Apr 04 '24 09:04 victorvermot

Hi @sebalix, @jbaudoux, @mt-software-de, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Apr 04 '24 09:04 OCA-git-bot

ping @lmignon @rousseldenis

maybe we need to put singular instead of plural ?

jbaudoux avatar Apr 04 '24 10:04 jbaudoux

ping @lmignon @rousseldenis

maybe we need to put singular instead of plural ?

Where ? If in buttons, no.

rousseldenis avatar Apr 12 '24 05:04 rousseldenis

The forced context {"search_default_release_ready": 1} in action_picking_all is not very convenient as you only see by default the release ready deliveries. I would drop it.

jbaudoux avatar Apr 12 '24 08:04 jbaudoux

I removed the context @jbaudoux but it makes one test fail and I am not sure how to fix it

victorvermot avatar Apr 17 '24 14:04 victorvermot

@victorvermot You need to adapt the test to remove what you removed from the context. See stock_release_channel.tests.test_channel_action: FAIL: TestChannelAction.test_action_all

jbaudoux avatar May 07 '24 13:05 jbaudoux

ping @victorvermot

jbaudoux avatar May 22 '24 09:05 jbaudoux

@victorvermot Thanks. Can you squash commits ?

jbaudoux avatar May 27 '24 10:05 jbaudoux

@victorvermot Can you squash commits ?

jbaudoux avatar Jun 03 '24 11:06 jbaudoux

@jbaudoux Done

victorvermot avatar Jun 19 '24 07:06 victorvermot

/ocabot merge minor

sebalix avatar Jun 19 '24 08:06 sebalix

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 19 '24 09:06 OCA-git-bot

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-883-by-sebalix-bump-minor, awaiting test results.

OCA-git-bot avatar Jun 19 '24 09:06 OCA-git-bot

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-883-by-sebalix-bump-minor, awaiting test results.

OCA-git-bot avatar Jun 19 '24 09:06 OCA-git-bot

Congratulations, your PR was merged at 807ccf09d5e412750fa5e600e09bc5b0e2654659. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 19 '24 10:06 OCA-git-bot