server-backend icon indicating copy to clipboard operation
server-backend copied to clipboard
verified publisher icon OCA

[18.0][MIG] base_user_role_history: Migration to 18.0.

Open mcodes-o opened this issue 1 year ago • 4 comments

Migrated to 18.0

mcodes-o avatar Jan 28 '25 19:01 mcodes-o

@ThomasBinsfeld Since you're listed as a maintainer, do you have time to look at this PR? Thanks!

mcodes-o avatar Feb 19 '25 06:02 mcodes-o

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 07 '25 13:03 OCA-git-bot

LGTM, but some small findings:

Squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

@CRogos I've squashed the commits and pushed. Thanks for the review!

mcodes-o avatar Apr 06 '25 10:04 mcodes-o

@mcodes-o these need to be squashed too: image

CRogos avatar Apr 10 '25 14:04 CRogos

@mcodes-o are you still working on this?

CRogos avatar May 21 '25 15:05 CRogos

@mcodes-o are you still working on this?

CRogos avatar Jul 29 '25 06:07 CRogos

to bring this PR to an end, I've re-added the test file and created a new PR: https://github.com/OCA/server-backend/pull/376

@rousseldenis @etobella could you do a review

CRogos avatar Aug 27 '25 20:08 CRogos

/ocabot migration base_user_role_history

rousseldenis avatar Aug 28 '25 07:08 rousseldenis

Superseeded by #376

etobella avatar Aug 28 '25 07:08 etobella