rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard
verified publisher icon OCA

[18.0][MIG] fastapi_auth_jwt: Migration to 18.0

Open dnplkndll opened this issue 1 year ago • 10 comments

Depends on:

  • [ ] https://github.com/OCA/server-auth/pull/752
  • [x] https://github.com/OCA/rest-framework/pull/471

dnplkndll avatar Jan 16 '25 22:01 dnplkndll

@sbidoul I am stumped https://github.com/OCA/rest-framework/pull/490/commits/3924b660cbaee3099c6c4c4e3e6b50425240836c how do you troubleshoot the dependency error?

dnplkndll avatar Jan 17 '25 00:01 dnplkndll

/ocabot migration fastapi_auth_jwt

lmignon avatar Jan 17 '25 08:01 lmignon

@dnplkndll Can you please rebase? :pray:

grindtildeath avatar Jun 16 '25 16:06 grindtildeath

@grindtildeath

the conflict is resolved and code is fine now.

kobros-tech avatar Jun 17 '25 11:06 kobros-tech

@kobros-tech As you reacted here, I suppose this superseeds your PR #483 ?

yvaucher avatar Jul 28 '25 14:07 yvaucher

@kobros-tech As you reacted here, I suppose this superseeds your PR #483 ?

yes, I run both and compare them to each other to see which approach is the best. Thank you!

kobros-tech avatar Jul 28 '25 15:07 kobros-tech

@TomAlbrechtQuatra @yvaucher

how do you think now?

kobros-tech avatar Aug 26 '25 02:08 kobros-tech

@lmignon @sbidoul

The PR is clean and ready now for migration merge?

kobros-tech avatar Aug 31 '25 18:08 kobros-tech

@lmignon Thank you too, we love community open source cooperation :)

kobros-tech avatar Sep 01 '25 15:09 kobros-tech

@lmignon Shall I add your fix commit to the demo module? fastapi_auth_jwt_demo/tests/test_fastapi_auth_jwt_demo.py

kobros-tech avatar Sep 01 '25 15:09 kobros-tech