OCA
[FIX] report_substitute: avoid write over the mail template
Hi @sbejaoui, some modules you are maintaining are being modified, check this out!
@sbejaoui @jjscarafia @HviorForgeFlow Hello guys, could you review this fordwar-port of #994 ? Thanks a lot
Thank you for the manual FW @augusto-weiss !
I confirm this is needed in the 17 and 18 versions, and it is an important fix, because it will avoid a concurrency problem. For example, when validating and auto-sending invoices.
Best Regards
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-1001-by-HviorForgeFlow-bump-minor, awaiting test results.
@HviorForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1001-by-HviorForgeFlow-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@pedrobaeza could you take a quick look here? A solution does not come me up. It looks like an error with a cryptography dependency but, in the past the related module was merge with any problem.
https://github.com/OCA/reporting-engine/pull/991
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1001-by-HviorForgeFlow-bump-minor, awaiting test results.
Congratulations, your PR was merged at 561e0d2c8a94970d0e8bf63ce670405bb0a4bb7e. Thanks a lot for contributing to OCA. ❤️