queue icon indicating copy to clipboard operation
queue copied to clipboard
verified publisher icon OCA

[18.0][PORT] queue_job: remove dead jobs requeuer cron and automatically requeue dead jobs

Open sbidoul opened this issue 11 months ago • 4 comments

FW port of #748

sbidoul avatar Mar 03 '25 17:03 sbidoul

Hi @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 03 '25 17:03 OCA-git-bot

@sbidoul looks like you have to rewrite this to use savepoints?

hbrunn avatar Mar 21 '25 06:03 hbrunn

I'm note sure it's possible to test that with savepoints, since we test database locks.

@AnizR

sbidoul avatar Mar 21 '25 13:03 sbidoul

@hbrunn, I came up with the solution of loading test queue.job records within demo.

What do you think about it?

AnizR avatar Jun 02 '25 15:06 AnizR

Setting as draft. There is a conflicts and the tests need some rework.

sbidoul avatar Aug 20 '25 09:08 sbidoul

I reworked the tests and decided to isolate the tests in test_queue_job. Moreover, I managed to remove the .commit() calls.

AnizR avatar Sep 15 '25 08:09 AnizR

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Sep 15 '25 10:09 OCA-git-bot

/ocabot merge major

sbidoul avatar Sep 17 '25 14:09 sbidoul

On my way to merge this fine PR! Prepared branch 18.0-ocabot-merge-pr-749-by-sbidoul-bump-major, awaiting test results.

OCA-git-bot avatar Sep 17 '25 14:09 OCA-git-bot

Congratulations, your PR was merged at c6f5ba82859f0913ca91b67b9d72601961a8a904. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 17 '25 15:09 OCA-git-bot