queue icon indicating copy to clipboard operation
queue copied to clipboard

[IMP][16.0+] base_import_async: propagate context used during import

Open AnizR opened this issue 1 year ago • 6 comments

Context

I was doing an asynchronous import on "account.asset" and realized that my assets were created but not visible. After some investigation, I found that that it was caused by a field 'asset_type' that is set using the context key 'default_asset_type'

Proposition

I think that the context used during import should be propagate to the jobs created. Or, at least, every key starting by 'default_...' .

It could be easily done by modifying the function on base_import.import:

def _job_prepare_context_before_enqueue_keys(self):

Question

Since I know that it could generate a debate, I opened this issue before creating any PR.

Should we propagate the context? All of it? A sub part of it?

AnizR avatar Nov 20 '24 10:11 AnizR

This PR has some context: https://github.com/OCA/queue/pull/432 (and links to much more context :)

sbidoul avatar Nov 20 '24 10:11 sbidoul

This PR has some context: #432 (and links to much more context :)

Thanks! It gives more context but note that it refers to the "general" case and here, I would like to debate on the specific case of asynchronous import.

AnizR avatar Nov 20 '24 11:11 AnizR

At first sight, in the specific case of base_import_async it makes sense to pass the same context that would be passed to a regular import.

sbidoul avatar Nov 20 '24 11:11 sbidoul

There was https://github.com/OCA/queue/pull/407, but this was apparently driven by the lang use case and was closed when lang went into the context ?

sbidoul avatar Nov 20 '24 11:11 sbidoul

Also https://github.com/OCA/queue/pull/613

amh-mw avatar Nov 20 '24 13:11 amh-mw

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 25 '25 12:05 github-actions[bot]