queue icon indicating copy to clipboard operation
queue copied to clipboard

[15.0][IMP] Make default subchannel capacity configurable.

Open amh-mw opened this issue 1 year ago • 5 comments

Either ODOO_QUEUE_JOB_DEFAULT_SUBCHANNEL_CAPACITY may be set as an environment variable, or default_subchannel_capacity may be set in the [queue_job] config file stanza.

amh-mw avatar Oct 14 '24 15:10 amh-mw

Hi @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Oct 14 '24 15:10 OCA-git-bot

My own use case is that I run multi-company odoo with an environment like ODOO_QUEUE_JOB_CHANNELS=root:8,single:1. The single channel is for problem children that tend to generate an excess of SerializationFailure if executed in parallel. I've recently determined that those SerializationFailure are company-specific, so a channel per company would improve parallelism.

Per @sbidoul in OCA Discord

Undeclared channels are auto created at runtime, but with an unlimited capacity.

This setting allows me to limit the capacity of auto-created channels.

amh-mw avatar Oct 14 '24 15:10 amh-mw

Thanks for addressing this @amh-mw

I would have a preference for configuring this in the parent channel, instead of globally. Like this is done, for instance for the throttle config.

sbidoul avatar Oct 18 '24 09:10 sbidoul

I would have a preference for configuring this in the parent channel, instead of globally. Like this is done, for instance for the throttle config.

Understood. I will unfortunately not have time to circle back around to that request until next year. Would it be possible to mark this issuenostale?

amh-mw avatar Oct 22 '24 15:10 amh-mw

@amh-mw Count on me to repoen it if the stale bot closes it. ~Can you set it Draft?~ [done]

sbidoul avatar Oct 22 '24 15:10 sbidoul

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Feb 23 '25 12:02 github-actions[bot]

@sbidoul Version two ready for review.

amh-mw avatar Mar 06 '25 18:03 amh-mw

Reopening against 18.0 https://github.com/OCA/queue/pull/767

amh-mw avatar May 07 '25 18:05 amh-mw