queue icon indicating copy to clipboard operation
queue copied to clipboard

[17.0] [IMP] queue_job: HA job runner using session level advisory lock

Open qgroulard opened this issue 1 year ago • 1 comments

Forward port of https://github.com/OCA/queue/pull/668

qgroulard avatar Jul 18 '24 10:07 qgroulard

Hi @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jul 18 '24 10:07 OCA-git-bot

@guewen @sbidoul anything missing to get this one merged?

LoisRForgeFlow avatar Dec 05 '24 09:12 LoisRForgeFlow

It has been approved by @guewen here as well https://github.com/OCA/queue/pull/668 yet @sbidoul had to provide feedback on odoo.sh if I'm not mistaken.

simahawk avatar Dec 06 '24 07:12 simahawk

We deployed this on a 17.0 odoo.sh instance. It works and nobody yelled at us :)

Now this is not a high volume deployment.

I'm quite confident this PR is good, but we are going to deploy this on a couple of more intensive instances (not odoo.sh) to confirm. I would encourage others to to the same.

sbidoul avatar Dec 06 '24 08:12 sbidoul

Rebased

sbidoul avatar Dec 06 '24 08:12 sbidoul

Hi @sbidoul

Still no issues with this improvement from our side. How is it going in your instances? Do you think we can merge?

LoisRForgeFlow avatar Mar 17 '25 12:03 LoisRForgeFlow

Yes, let's merge. I have merged #748 and now this one.

Two great simplification in queue_job operations!

/ocabot merge minor

sbidoul avatar Mar 17 '25 13:03 sbidoul

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-673-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot avatar Mar 17 '25 13:03 OCA-git-bot

Congratulations, your PR was merged at bd16ee3ba003b6f0611971a1096718d670b5fc00. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Mar 17 '25 13:03 OCA-git-bot