queue icon indicating copy to clipboard operation
queue copied to clipboard

Fix for randomized retry interval format

Open InigoGR opened this issue 2 years ago • 5 comments

queue_job: fix retry format with tuple values

https://github.com/OCA/queue/pull/348 added support for randomized retry intervals. I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

InigoGR avatar Feb 01 '24 09:02 InigoGR

Hi @guewen, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Feb 01 '24 09:02 OCA-git-bot

Thanks for your contrib! I guess it failed because we didn't have specific tests, right? Any chance you add that? If you don't have time that's fine, but it's a really nice to have if you can 😉

Also, could you please rewrite the commit msg to something like:

queue_job: fix retry format with tuple values

#348 added support for randomized retry intervals.
I could not set randomized retry intervals due to the formatting checks not being updated. This should fix it.

What changes:

  1. includes module name
  2. includes the full description of the issue

I will add test coverage for that case and change the commit message.

InigoGR avatar Feb 01 '24 14:02 InigoGR

Added some simple tests that should cover the changes in _check_retry_pattern and _parse_retry_pattern.

InigoGR avatar Feb 05 '24 09:02 InigoGR

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 08 '24 10:03 OCA-git-bot

@simahawk Is this good to merge?

dreispt avatar May 02 '24 15:05 dreispt

/ocabot merge patch

dreispt avatar May 18 '24 18:05 dreispt

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-624-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar May 18 '24 18:05 OCA-git-bot

Congratulations, your PR was merged at cf35a44277c63d70b84e6a7bd79cee138be0f5fe. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 18 '24 18:05 OCA-git-bot