purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard

[16.0] purchase_order_ line_receipt_status: Add nothing value

Open grindtildeath opened this issue 1 year ago • 4 comments

grindtildeath avatar Jun 07 '24 17:06 grindtildeath

ping @imlopes

grindtildeath avatar Jun 07 '24 17:06 grindtildeath

@grindtildeath pre-commit fails ⚠️

imlopes avatar Jun 10 '24 10:06 imlopes

Tests fail due to interaction with purchase_order_no_zero_price. Can you easily amend this in your own test perhaps?

2024-06-10T14:58:32.7039558Z 2024-06-10 14:58:32,702 467 [1;31m[1;49mERROR[0m odoo odoo.addons.purchase_order_line_receipt_status.tests.test_order_line_receipt_status: ERROR: TestPurchaseOrderLineReceiptStatus.test_line_receipt_status
2024-06-10T14:58:32.7041267Z Traceback (most recent call last):
2024-06-10T14:58:32.7042901Z   File "/__w/purchase-workflow/purchase-workflow/purchase_order_line_receipt_status/tests/test_order_line_receipt_status.py", line 52, in test_line_receipt_status
2024-06-10T14:58:32.7044445Z     backorder_wizard.process_cancel_backorder()
2024-06-10T14:58:32.7045739Z   File "/opt/odoo/addons/stock/wizard/stock_backorder_confirmation.py", line 76, in process_cancel_backorder
2024-06-10T14:58:32.7047031Z     .button_validate()
2024-06-10T14:58:32.7047818Z   File "/opt/odoo/addons/stock/models/stock_picking.py", line 1107, in button_validate
2024-06-10T14:58:32.7049052Z     pickings_not_to_backorder.with_context(cancel_backorder=True)._action_done()
2024-06-10T14:58:32.7050195Z   File "/opt/odoo/addons/sale_stock/models/stock.py", line 86, in _action_done
2024-06-10T14:58:32.7051015Z     res = super()._action_done()
2024-06-10T14:58:32.7051852Z   File "/opt/odoo/addons/stock/models/stock_picking.py", line 911, in _action_done
2024-06-10T14:58:32.7053204Z     todo_moves._action_done(cancel_backorder=self.env.context.get('cancel_backorder'))
2024-06-10T14:58:32.7054385Z   File "/opt/odoo/addons/stock_account/models/stock_move.py", line 257, in _action_done
2024-06-10T14:58:32.7055523Z     res = super(StockMove, self)._action_done(cancel_backorder=cancel_backorder)
2024-06-10T14:58:32.7056913Z   File "/opt/odoo/addons/stock/models/stock_move.py", line 1848, in _action_done
2024-06-10T14:58:32.7058399Z     backorder_moves.with_context(moves_todo=moves_todo)._action_cancel()
2024-06-10T14:58:32.7059505Z   File "/opt/odoo/addons/stock_account/models/stock_move.py", line 35, in _action_cancel
2024-06-10T14:58:32.7060409Z     return super()._action_cancel()
2024-06-10T14:58:32.7061258Z   File "/opt/odoo/addons/stock/models/stock_move.py", line 1751, in _action_cancel
2024-06-10T14:58:32.7062129Z     moves_to_cancel._do_unreserve()
2024-06-10T14:58:32.7062961Z   File "/opt/odoo/addons/stock/models/stock_move.py", line 875, in _do_unreserve
2024-06-10T14:58:32.7063813Z     ml_to_unlink.unlink()
2024-06-10T14:58:32.7064553Z   File "/opt/odoo/addons/stock/models/stock_move_line.py", line 506, in unlink
2024-06-10T14:58:32.7065771Z     res = super(StockMoveLine, self).unlink()
2024-06-10T14:58:32.7066455Z   File "/opt/odoo/odoo/models.py", line 3569, in unlink
2024-06-10T14:58:32.7067075Z     self.env.flush_all()
2024-06-10T14:58:32.7067617Z   File "/opt/odoo/odoo/api.py", line 745, in flush_all
2024-06-10T14:58:32.7068251Z     self._recompute_all()
2024-06-10T14:58:32.7068822Z   File "/opt/odoo/odoo/api.py", line 741, in _recompute_all
2024-06-10T14:58:32.7069809Z     self[field.model_name]._recompute_field(field)
2024-06-10T14:58:32.7070599Z   File "/opt/odoo/odoo/models.py", line 6274, in _recompute_field
2024-06-10T14:58:32.7071314Z     field.recompute(records)
2024-06-10T14:58:32.7071923Z   File "/opt/odoo/odoo/fields.py", line 1370, in recompute
2024-06-10T14:58:32.7072657Z     apply_except_missing(self.compute_value, recs)
2024-06-10T14:58:32.7073485Z   File "/opt/odoo/odoo/fields.py", line 1343, in apply_except_missing
2024-06-10T14:58:32.7074206Z     func(records)
2024-06-10T14:58:32.7074758Z   File "/opt/odoo/odoo/fields.py", line 1392, in compute_value
2024-06-10T14:58:32.7075467Z     records._compute_field_value(self)
2024-06-10T14:58:32.7076206Z   File "/opt/odoo/odoo/models.py", line 4237, in _compute_field_value
2024-06-10T14:58:32.7077123Z     self.filtered('id')._validate_fields(fnames)
2024-06-10T14:58:32.7077893Z   File "/opt/odoo/odoo/models.py", line 1359, in _validate_fields
2024-06-10T14:58:32.7084778Z     check(self)
2024-06-10T14:58:32.7092579Z   File "/__w/purchase-workflow/purchase-workflow/purchase_order_no_zero_price/models/purchase_order_line.py", line 26, in _check_price_unit_zero
2024-06-10T14:58:32.7093775Z     raise exceptions.UserError(
2024-06-10T14:58:32.7094431Z odoo.exceptions.UserError: Missing unit price for Products: [DESK0005] Customizable Desk (Custom, White)

StefanRijnhart avatar Aug 05 '24 12:08 StefanRijnhart

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Nov 02 '25 12:11 github-actions[bot]