OCA
[15.0][MIG] project_key
Standard migration of the project_key module.
See #1055 for comments and history
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@vincent-hatakeyama Could you improve commit message:
Like
[IMP] project_key: ...? Thanks
That looked like a fix rather than an improvement. I’ve rebased and edited the commit message
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
Functional 👍
why are there commits after the migration commit?
First message indicates:
See https://github.com/OCA/project/pull/1055 for comments and history
It was suggested to port some fixes/changes in the original PR.
Thanks for the feedback, but there’s no plan for us to work on this PR.
There’s two possibilities:
- I close the PR and someone can use it as a basis for the migration of the module.
- I keep it and someone opens a PR on our fork to update this.
If I don’t have any answer for a while, I’ll just close the PR.
I just created #1570 which is a fork of your work plus the fix discussed recently.
