[14.0] [mig] pos_fix_search_limit

[fshah-initos]

[hkapatel-initos]

It would be nice if we could get reviews here.

[hkapatel-initos]

Hello, @ivantodorovich can you please check it again so we should merge it ASPS.

[ivantodorovich]

Hello, @ivantodorovich can you please check it again so we should merge it ASPS.

Hi, the implementation changed a lot and it was significatly simplified. I don't use this module so I don't have enough knowledge to review. I rather the original module's authors / contributors review this.

[hkapatel-initos]

Hello, @hparfr and @dalonsod it would be great if you both can add reviews here.

[hparfr]

Pos_fix_search_limit can't be migrated without lot of code changes. The new layout of functions don't allow enough modularity. So I integrated this feature in the pos_product_template here:

https://github.com/akretion/pos/commit/d8727220bbeea112c0d81ee4c30944e8a4900c2e#diff-3e277683278bdd486fadd6746e8669da4432e49edddbd6f24b66343f83b0b51eR91

Do you need pos_fix_search_limit in another context ?

[dsolanki-initos]

Hello, @hparfr and @ivantodorovich it would be nice if you re-check.

[dsolanki-initos]

Hello, @hparfr and @ivantodorovich it would be nice if you re-check this pull.

[dsolanki-initos]

Hello, @hparfr and @ivantodorovich it would be nice if you re-check this pull.

[dsolanki-initos]

@ivantodorovich could you check this pull and approve it?

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ikapasi-initos]

Hi,@ivantodorovich could you check this pull and approve it?

[ikapasi-initos]

Hello, @hparfr could you check this pull and approve it?

[legalsylvain]

Closing, as question from @hpar is unanswered since 1 year.

Feel free to reopen after having answered. Thanks.