operating-unit icon indicating copy to clipboard operation
operating-unit copied to clipboard

[14.0][IMP] sale_operating_unit: allowed to hide operating_unit_id in list views

Open alexeirivera87 opened this issue 1 year ago • 8 comments

added optional="hide"

alexeirivera87 avatar Apr 10 '24 18:04 alexeirivera87

Hello @AaronHForgeFlow

Could you please check this small adjustment?

regards

alexeirivera87 avatar Apr 10 '24 18:04 alexeirivera87

put optional="show" instead

That way there is no changes for current users.

AaronHForgeFlow avatar Apr 11 '24 07:04 AaronHForgeFlow

@AaronHForgeFlow

It's done.

regards

alexeirivera87 avatar Apr 16 '24 20:04 alexeirivera87

@alexeirivera87 Thanks. You can add yourself in the the contributors.rst file but please do not change Readme.rst file. The oca bot will do that.

AaronHForgeFlow avatar Apr 17 '24 07:04 AaronHForgeFlow

@alexeirivera87 Thanks. You can add yourself in the the contributors.rst file but please do not change Readme.rst file. The oca bot will do that.

@AaronHForgeFlow Ah, copied. I did not know that. Should I revert the change in the readme file? In order to get this PR approved/merged?

alexeirivera87 avatar May 14 '24 13:05 alexeirivera87

@alexeirivera87 no, it is not that important

AaronHForgeFlow avatar May 14 '24 14:05 AaronHForgeFlow

I don't mind to merge it just waiting for some other users to approve

AaronHForgeFlow avatar May 14 '24 14:05 AaronHForgeFlow

Hello @MiquelRForgeFlow

I saw you approved other PR in this repository. Could you please check this one? Thanks in advance.

alexeirivera87 avatar Jul 12 '24 13:07 alexeirivera87

Hello @AaronHForgeFlow

Can this PR be merged?

regards

alexeirivera87 avatar Sep 12 '24 14:09 alexeirivera87

ok, let's do it, it is a minor change. The other needed approval is implicit in the other comment.

/ocabot merge minor

AaronHForgeFlow avatar Sep 12 '24 14:09 AaronHForgeFlow

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-657-by-AaronHForgeFlow-bump-minor, awaiting test results.

OCA-git-bot avatar Sep 12 '24 14:09 OCA-git-bot

Congratulations, your PR was merged at 021d5bb4d208a8830ebc0016845605a3a2113e24. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 12 '24 14:09 OCA-git-bot