operating-unit icon indicating copy to clipboard operation
operating-unit copied to clipboard

[15.0][ENH] hr_operating_unit: add OU to department

Open ps-tubtim opened this issue 2 years ago • 6 comments

Adds an operating unit to the department

Selection_182

ps-tubtim avatar Feb 14 '23 04:02 ps-tubtim

This PR fixed domain users in hr.employee

Selection_012

Saran440 avatar Mar 08 '23 04:03 Saran440

I am not a user of this module, but this change seems legit. I would recommend to do a migration script to prefill the information in the department.

AaronHForgeFlow avatar Jun 07 '23 10:06 AaronHForgeFlow

@AaronHForgeFlow I think this enhance shouldn't migration script because all department will default 1 OU

Example:

Case 1 (No script) Deparmtent A - No OU Deparmtent B - No OU Deparmtent C - No OU Deparmtent D - No OU

Case 2 (there is script) Deparmtent A - OU 1 Deparmtent B - OU 1 Deparmtent C - OU 1 Deparmtent D - OU 1

Case1 all user can see department Case2 user OU1 can see all department, it must change some department to correct OU I think case1 is makesense more than

What do you think?

Saran440 avatar Jun 09 '23 09:06 Saran440

@Saran440 , I think that makes sense.

Would it make sense to put a restriction so the operating unit of the employee cannot be different from the operating unit of the department?

In any case I am not using this module and I prefer actual users to discuss this.

AaronHForgeFlow avatar Jun 09 '23 09:06 AaronHForgeFlow

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 09 '23 10:06 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 19 '24 12:05 github-actions[bot]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 29 '24 12:12 github-actions[bot]