OCA
[16.0][FIX] mis_builder: correctly compute context in mis_report_widget
This PR ensures that the context used by the mis_report_widget widget RPC calls is correctly computed.
Previously using the mis_analytic_domain context key was useless as not taken into account in the widget.
Hi @sbidoul, some modules you are maintaining are being modified, check this out!
This seems to break the filter. On runboat, I tried this filter with the demo report
And I got this error
The same works on 16.0
This seems to break the filter. On runboat, I tried this filter with the demo report
And I got this error
The same works on 16.0
Oops Indeed I forgot to return the Domain as a list and not as an ast Domain.
Yes, I tested, this works fine now.
Wondering if the search bar widget is capable of loading and displaying the value from the context.
Yes, I tested, this works fine now.
Wondering if the search bar widget is capable of loading and displaying the value from the context.
I'll have a look and also about the fact that the filters would be returned to this view when modified on the drilldown one. I am wondering whether we could use the globalstate in order to achieve this but I need a bit more of research. Or in another PR? Let me know 🙂
@sbidoul Actually, the domain cannot be displayed as this does not correspond to a filter, but if filters are set in the context we should indeed use them. I do not know if it is the case. I'll have a look.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @sbidoul, some modules you are maintaining are being modified, check this out!