mis-builder icon indicating copy to clipboard operation
mis-builder copied to clipboard
verified publisher icon OCA

[16.0] Custom fields in accounting expressions

Open sbidoul opened this issue 2 years ago • 2 comments

This is a very rough experiment on the Accounting Expression Processor to support expressions such as fldp.quantity[60%]

This will read the quantity field in the same read_group as debit and credit so we can write efficient expressions on any numerical field that is available in the move-line-like table.

TODO

  • [ ] add tests
  • [x] fix failing tests
  • [ ] update legend
  • [ ] update docs

sbidoul avatar Nov 15 '23 17:11 sbidoul

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 17 '24 12:03 github-actions[bot]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 08 '24 12:09 github-actions[bot]

This is ready to go. I added tests and documentation.

Very useful to combine quantities (say, hours) with accounting data in the same MIS report.

sbidoul avatar Nov 11 '24 18:11 sbidoul

/ocabot merge minor

sbidoul avatar Dec 11 '24 11:12 sbidoul

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-584-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot avatar Dec 11 '24 11:12 OCA-git-bot

Congratulations, your PR was merged at fa2375157ebbf51428d7247f2fa1d2ae33c0570d. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Dec 11 '24 11:12 OCA-git-bot

I see that the changes added here have lost an interesting functionality (which existed in v16 and exists in v15). Before, in comparison mode (2023 vs 2024 for example) accounts with no data will not be shown, now they are all shown (even if they have no data in any of the periods). It seems to be related to https://github.com/OCA/mis-builder/commit/edaee9b3211e245d3c2a704c23d9fec8c9a653ad#diff-c78e2ca554b9359f0e967b6ab457d608b0030631f2b73e2e31f5942457cb11c0R401 but I am not clear about the proper fix, because there are other related changes, can you check it? Thanks.

victoralmau avatar Dec 18 '24 09:12 victoralmau

cc @sbidoul

pedrobaeza avatar Dec 18 '24 09:12 pedrobaeza

Ah, sorry if this caused a regression. I'll have a look in the coming days. Could you create a separate issue and if possible a little more explanation as I'm not sure I fully understand the issue.

sbidoul avatar Dec 18 '24 09:12 sbidoul

Ah, sorry if this caused a regression. I'll have a look in the coming days. Could you create a separate issue and if possible a little more explanation as I'm not sure I fully understand the issue.

Of course, created and explained with a use case. https://github.com/OCA/mis-builder/issues/665

victoralmau avatar Dec 18 '24 09:12 victoralmau