Rename repository and modules
Thinking especially in v19 I think it would be appropriate to take advantage of the migration of the modules to rename them properly, I think the right approach would be:
-
github_connector: it would be renamed togit_interface. All models and field names containing “github” should be renamed to “git”. ThePyGithubdependency of the module would be removed. A field (git_source) would be added (e.g. in organizations) to indicate the source (github/gitlab, etc). -
git_interface_github: ThePyGithubdependency would be added and what “github_connector” currently has regarding the connection to github would be moved. -
github_connector_odoo: It would be renamed togit_interface_odooand would only have thegit_interfacemodule dependency.
This approach would allow to add other sources and create for example a new git_interface_gitlab module that would allow to add the gitlab organizations/repositories/modules “with almost no effort” because the main logic would already be in git_interface.
For consistency with all this, a new OCA/interface-git repository (or similar) should be created to move the modules in v19 to that repository.
What do you think?
Ping @pedrobaeza
because the main logic would already be in github_connector.
because the main logic would already be in git_connector.
I guess.
Otherwise, totaly agree with such move.
Yes, I think we should start renaming the repository to interface-git (the previous names remains as an alias, so no compatibility problem), then I would like to get rid of connector word, as this is not using such modules for "connecting" to GitHub, so git_interface, git_interface_odoo can be possible names.