OCA
[17.0][MIG] base_geoengine: Migration to 17.0
Module migrated to version 17.0
cc https://github.com/APSL 154489 @miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review
- [Issue] https://github.com/OCA/geospatial/issues/349
To do:
- [ ] As an admin, if I change the domain of a layer with the filter button then the change are persisted in database.
- [ ] As a user, if I change the domain of a layer with the filter button then the change are not persisted in database. There are just the changes in the display.
- [ ] As an admin,If the geoengine view is in edit mode, I can create new records by drawing them in the view.
Hi @pedrobaeza and @reichie020212,
We used some code from @reichie020212 previous closed migration PR (https://github.com/OCA/geospatial/pull/357) and co-authored the migration commit.
Is this correct?
Yes, it seems OK. Please put the module name in the migration commit.
Done. Thanks!
I have noticed some issue in the JavaScript code of the controller in the modelParams function. It uses this.props.state.modelState twice without a ? operator and in my tests on base_geoengine_demo this.props.state comes undefined.
Other controllers like in form, list or kanban are using a ? also.
Some other things that I have noticed that need to be solved:
- Gist indexes are not created even if requested. This was fixed in 12.0 but not in subsequent ones.
- In the widget component, reprojection using 'ol.format.GeoJSON' is not well defined. So other srid than 3857 cannot be used.
- The RecordsPanel is currently commented.
I'm actively working on this version at the moment and everything looks fine except for two things that I will try to solve ~~this week~~ today:
- The id associated with 'ol_map' is not enough to identify it with 'Date.now()' because the same form view can have several ending up with the same id.
- Recover and complete the RecordsPanel.
Tested functionally from #372. LGTM.
Sorry but I didn't tested following the 'base_geoengine_demo' readme and trying to follow those indications still are some bugs.
I just realized that the custom domain selector for geometries is completely broken. Odoo 17 doesn't allow overloading domain selection of custom field types as easily as before with:
registry.category("domain_selector/fields")
There is going to be a lot of work in that part.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@peluko00
Tx to your commit. Seams everything is ok to merge, is`n it?
@peluko00
Tx to your commit. Seams everything is ok to merge, is`n it?
Not yet, they are some bugs to solve
@peluko00
Your last commit fix unit test. So we are ready to merge with the branch.
Is there any bug or issues?
I check it with odoo 17 manually and every thing seams ok.
Let me know if there is any issue, pleas.
BTW, I can help you to finish it,
TX to your work, hope be fine
@peluko00
Your last commit fix unit test. So we are ready to merge with the branch.
Is there any bug or issues?
I check it with odoo 17 manually and every thing seams ok.
Let me know if there is any issue, pleas.
BTW, I can help you to finish it,
TX to your work, hope be fine
Yes, the bugs are in the TODO description of this PR. If you wanna to solve that make a pr to merge into my branch. Thanks in advance
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-368-by-dreispt-bump-nobump, awaiting test results.
Congratulations, your PR was merged at dc17fccbd29cf503a4aaf744741e96976cc1da58. Thanks a lot for contributing to OCA. ❤️