contract icon indicating copy to clipboard operation
contract copied to clipboard

[14.0][FIX] contract: fix compute_recurring_next_date for recurring_r…

Open mourad-ehm opened this issue 3 years ago • 2 comments

contract: fix compute_recurring_next_date for recurring_rule_type = "monthlylastday" before fix : When you change value of recurring_rule_type (ex you pass from "monthly" to "monthlylastday" or "weekly") or you change recurring_invoicing_type (ex: from "post-paid" to "pre-paid") or recurring_interval (every 1 to every 2 "month") ==> the recurring_next_date remain unchanged. ex: recurring_next_date = 2022-07-01 and recurring_rule_type (from "monthly" to "monthlylastday" ) ==> recurring_next_date = 2022-07-01 After fix: When you change value of recurring_rule_type (ex pass from "monthly" to "monthlylastday" or "weekly") or you change recurring_invoicing_type (ex: from "post-paid" to "pre-paid") or recurring_interval (from every 1 to every 2 "month") ==> the recurring_next_date is updated based on this new parameters. ex: recurring_next_date = 2022-07-01 and recurring_rule_type (from "monthly" to "monthlylastday" ) ==> recurring_next_date = 2022-06-30

mourad-ehm avatar May 16 '22 12:05 mourad-ehm

ping @pedrobaeza @hparfr

mourad-ehm avatar May 17 '22 07:05 mourad-ehm

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 02 '22 12:10 github-actions[bot]

ping @hparfr

mourad-ehm avatar Oct 27 '22 09:10 mourad-ehm