contract [14.0][MIG] agreement_legal_sale_fieldservice (Version 12.0 to 14.0)

Depends on:

agreement_legal_sale #672
fieldservice_agreement https://github.com/OCA/field-service/pull/781
fieldservice_sale https://github.com/OCA/field-service/pull/761

May 13 '21 20:05 patrickrwilson

@patrickrwilson Can you rebase this branch?

Dec 03 '21 09:12 dsolanki-initos

@patrickrwilson Can you make Travis happy?

Dec 10 '21 07:12 dsolanki-initos

@patrickrwilson It would be nice if you can make Travis green

Jan 19 '22 12:01 dsolanki-initos

Hello @patrickrwilson, can you please modify test cases to make travis green?

Feb 04 '22 09:02 dsolanki-initos

@patrickrwilson can we see the travis green?

Feb 18 '22 06:02 dsolanki-initos

@dsolanki-initos unless i'm missing something, Travis is fine with this module but unhappy with aggreement_sale. I'm not sure how to fix that in this PR.

Feb 18 '22 20:02 patrickrwilson

@patrickrwilson as you have write test cases so there is field name "tracking" which is required and you are not adding values for it in the test case. can you please modified and check it for make travis happy.

May 06 '22 09:05 dsolanki-initos

@patrickrwilson can we see the travis green?

May 20 '22 09:05 dsolanki-initos

@patrickrwilson can you please check failed checks?

Jun 03 '22 09:06 dsolanki-initos

@patrickrwilson can we see travis green?

Jun 17 '22 10:06 dsolanki-initos

/ocabot migration agreement_legal_sale_fieldservice

Jun 18 '22 13:06 rousseldenis

/ocabot rebase

Jun 18 '22 13:06 rousseldenis

Congratulations, PR rebased to 14.0.

Jun 18 '22 13:06 OCA-git-bot

@patrickrwilson Could you fix this ? Thanks

Jun 18 '22 13:06 rousseldenis

@patrickrwilson Can you please fix failed checks?

Jun 24 '22 08:06 dsolanki-initos

I'm not sure how to fix this, pointers?

Jun 24 '22 12:06 patrickrwilson

I'm not sure how to fix this, pointers?

Have you installed pre-commit before committing ?

Jun 24 '22 12:06 rousseldenis

I'm fairly certain I did however it's been over a year since I committed this. I will try to take a look at this again but may be a bit till I can, if someone else wants to take this over feel free to do so.

Jun 24 '22 12:06 patrickrwilson

@patrickrwilson can you please fail check?

Sep 16 '22 08:09 dsolanki-initos

@patrickrwilson You do not need to define "tracking" to "none" by default it is "none" so you can remove it.

Sep 23 '22 08:09 dsolanki-initos

@dsolanki-initos I removed the tracking: none in test but isn't it failing on agreement_legal module tests and not this one? I could be reading this wrong.

Sep 23 '22 12:09 patrickrwilson