contract icon indicating copy to clipboard operation
contract copied to clipboard

[16.0][IMP] subscription_oca: Various improvements

Open tarteo opened this issue 1 year ago • 2 comments

Fixes improvements mentioned here: https://github.com/OCA/contract/issues/1057

tarteo avatar Mar 14 '24 10:03 tarteo

Not sure why the codecov/patch check is failing because codecov says there's a positive change (+0.03%)

image

tarteo avatar Mar 14 '24 11:03 tarteo

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 28 '24 12:07 github-actions[bot]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 26 '25 12:01 github-actions[bot]

@OCA/community-maintainers There's no team for contract maintainers. Can anyone decide if this can be merged or not, please. Codecov is failing but I don't know how I can increase test coverage in a meaningful way without creating bs tests.

tarteo avatar Jan 28 '25 11:01 tarteo

@OCA/project-service-maintainers :wink:

simahawk avatar Jan 28 '25 14:01 simahawk

@simahawk Ah thanks! :smile:

tarteo avatar Jan 28 '25 14:01 tarteo

@rousseldenis Thanks! I will look this week on how to extend the tests (in a meaningful way) to cover more code.

tarteo avatar Jan 29 '25 09:01 tarteo

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 07 '25 14:02 OCA-git-bot

@rousseldenis @OCA/project-service-maintainers Can we please merge this? Let me know

tarteo avatar Feb 21 '25 09:02 tarteo

@tarteo Could you squash the merge commit ? Thanks

rousseldenis avatar Mar 12 '25 12:03 rousseldenis

@rousseldenis Fixed it :)

tarteo avatar Mar 12 '25 13:03 tarteo

/ocabot merge minor

dreispt avatar Mar 16 '25 18:03 dreispt

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-1058-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot avatar Mar 16 '25 18:03 OCA-git-bot

Congratulations, your PR was merged at 158cbe499dae6c652ec500657e3d45d403d292fb. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Mar 16 '25 18:03 OCA-git-bot