connector-interfaces icon indicating copy to clipboard operation
connector-interfaces copied to clipboard

[14.0][FIX] connector_importer: skip_fields_unchanged

Open raumschmiede-joshuaL opened this issue 1 year ago • 4 comments

When skip_fields_unchanged is set for the record handler, the behaviour comparing existing with new values raises an error because read returns a list and another one, that id is not in values. And the operator is wrong. Currently it would import the values only if they are the same as the existing.

I added a FIXME for later to convert the new values. Is this ok?

raumschmiede-joshuaL avatar Jun 21 '24 10:06 raumschmiede-joshuaL

Hi @simahawk, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jun 21 '24 10:06 OCA-git-bot

@i-vyshnevska

raumschmiede-joshuaL avatar Jun 21 '24 10:06 raumschmiede-joshuaL

Shall I update the module version?

raumschmiede-joshuaL avatar Jun 21 '24 11:06 raumschmiede-joshuaL

Shall I update the module version?

this will be done by bot on merge

vuwnevska avatar Jun 25 '24 16:06 vuwnevska

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 27 '24 12:10 github-actions[bot]