OCA
[MIG] openupgrade_framework, base v17
This is preliminary because I didn't yet go through all analysis to migrate them, but this lets the base migration run without crashing
TODOs:
- [x] verify we still need all monkey patches and no new ones
- [x] mig base (partial)
Check the comments at #4327 and please also remove the commit and the revert that are next to each other as useless to clean commit history.
Check the comments at #4327 and please also remove the commit and the revert that are next to each other as useless to clean commit history.
@duong77476-viindoo Please help me handle this PR, I have given you permission to push into my forked repo Or you can close it to do another pr
Check the comments at #4327 and please also remove the commit and the revert that are next to each other as useless to clean commit history.
@duong77476-viindoo Please help me handle this PR, I have given you permission to push into my forked repo Or you can close it to do another pr
Okay
Hi I have followed up some comments in https://github.com/OCA/OpenUpgrade/pull/4327 by Mr @StefanRijnhart and comment https://github.com/OCA/OpenUpgrade/pull/4427#issuecomment-2111663562 by @pedrobaeza Please continue review, thanks I also split base migration into another pr https://github.com/OCA/OpenUpgrade/pull/4430 and make a mail migration also at https://github.com/OCA/OpenUpgrade/pull/4431
P/S: How can i add v16 test database
Can you help me here? I asked on #4327 to remove https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_framework/odoo_patch/odoo/tests/loader.py, and it's certainly gone here but it's not removed in the migration commit. Where is it removed?
16.0 reference database is now added to https://github.com/OCA/OpenUpgrade/releases/tag/databases.
Can you help me here? I asked on #4327 to remove https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_framework/odoo_patch/odoo/tests/loader.py, and it's certainly gone here but it's not removed in the migration commit. Where is it removed?
I drop that commit (using git rebase and drop) outside of this PR, so you mean that i need to keep it and make another commit to remove it?
16.0 reference database is now added to https://github.com/OCA/OpenUpgrade/releases/tag/databases.
Thank you
Can you help me here? I asked on #4327 to remove https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_framework/odoo_patch/odoo/tests/loader.py, and it's certainly gone here but it's not removed in the migration commit. Where is it removed?
I drop that commit (using git rebase and drop) outside of this PR, so you mean that i need to keep it and make another commit to remove it?
Yes please! You can remove the code in the migration commit. That way, we keep neatly track of the changes per version.
@StefanRijnhart OK, then can i cherry-pick that commit then i'll create a commit to remove .Meaning that the test commit and its removal will come on top. Is it ok ?
@duong77476-viindoo Actually, that's not conventional. Please back-up this branch to another name (can be locally), then reset the branch and redo the git format-patch method with which this branch was created in the first place. Then cherry-pick your migration commit, then amend the migration commit.
@StefanRijnhart Hello, i have done what you advised, please review, thanks