Arazzo-Specification icon indicating copy to clipboard operation
Arazzo-Specification copied to clipboard

json schema: fix Criterion Object

Open markus-96 opened this issue 10 months ago • 3 comments

see #336

this is my first PR to this project, so I am happy if you tell me if it meets your expectations :)

If needed, I can also try to take part in the meeting coming in two weeks.

reading https://github.com/OAI/Arazzo-Specification/issues/337#issuecomment-2773136822 ("Need to digest https://github.com/OAI/Arazzo-Specification/issues/336 before discussing"), maybe this helps:

I would consider the following class diagram for modelling a Criterion Object:

grafik

markus-96 avatar Apr 04 '25 13:04 markus-96

@markus-96 thanks for the PR. Would you be able to take a look at the feedback from @jeremyfiel? Also, can you target v1.0-dev branch with this PR?

frankkilcommins avatar Apr 30 '25 08:04 frankkilcommins

@markus-96 appreciate your patience here. I was holding off on approving during to pending infra changes. Those infra changes are not merged, and we've changed the schema directory locations to align with the OpenAPI Specification repos.

Would you be able to update your PR to make the changes against the new schema locations, and also take a look at @jeremyfiel comments above?

frankkilcommins avatar Jul 04 '25 14:07 frankkilcommins

@markus-96 gentle reminder here. Would you be able to update your PR to make the changes against the new schema locations, and also take a look at @jeremyfiel comments above?

frankkilcommins avatar Oct 01 '25 13:10 frankkilcommins