NullVoxPopuli
Consistent test runs
This uses pnpm dlx to run a specific version of ember-cli. That should make the tests consistent without requiring ember-cli to be installed globally. We can't use a devDependency here since ember-cli then thinks this is an Ember project and refuses to run the app generator.
Closes #450
![bolt-new-by-stackblitz[bot] avatar](https://avatars.githubusercontent.com/in/182710?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚠️ No Changeset found
Latest commit: 1552f4ae0c3d49ebf783a506fa868932ec455199
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
@NullVoxPopuli it seems one of the issues is the timeout on windows. I can increase the value again, but there seem to be some snapshot mismatches as well which didn't fail on linux? Any idea what's up?
Snapnhots probably need to be updated. Because the output of ember new is tested, and that changes kinda frequently
Yea, but I tried to find the version that you last used to update the snapshots and 5.1 seemed to pass the tests locally. It also doesn't fail under ubuntu-latest. It's strange that only the windows version fails here, but maybe something else is up.
I wonder if we need to expose all the logs so we can see what's going on. I find it very suspicious that every windows test is timing out, too
Doing some open PR cleanup, and I don't really have time / motivation to push this over the finish, so I'm closing instead. Sorry!