CountersPlus icon indicating copy to clipboard operation
CountersPlus copied to clipboard

Account for Modifier score changes

Open DekuSkrub2129 opened this issue 1 year ago • 2 comments

I've been using this mod for a while now, and it used to show PB percentage, while accounting for modifiers. Now, modifiers seem to be ignored, and the mod shows the percentage compared to the base score.

For example, a perfect score with no modifiers will show as 100%, regardless of modifiers used after that. Previously, the PB would show the accuracy you'd need with those modifiers, so that same perfect PB would show as 92.5% if you turned on Faster Song. If your PB is above that 100% base score, this part of the mod is mostly useless.

I loved this feature, as it made it really easy to track my performance in-game in relation to my PB. If it's possible, please bring this feature back.

Adding this in for better context, I'm on game version 1.37.2, and mod version 2.3.7

DekuSkrub2129 avatar Aug 17 '24 01:08 DekuSkrub2129

Which version are you coming from? I've been working on the project for roughly 8 months and haven't modified anything to do with the pb counter (going from memory atleast)

NuggoDEV avatar Sep 13 '24 13:09 NuggoDEV

Unfortunately, I'm not sure how far back this goes. I'm pretty sure it goes back to at least 1.29, but I can't confirm anything before that.

In terms of mod version, I'm also not certain.

On Fri, Sep 13, 2024, 06:45 Riley Prince @.***> wrote:

Which version are you coming from? I've been working on the project for roughly 8 months and haven't modified anything to do with the pb counter (going from memory atleast)

— Reply to this email directly, view it on GitHub https://github.com/NuggoDEV/CountersPlus/issues/144#issuecomment-2349000917, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASJ5DG4VBPQDCOKIXMAVFBTZWLT6FAVCNFSM6AAAAABMU6SPKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZGAYDAOJRG4 . You are receiving this because you authored the thread.Message ID: @.***>

DekuSkrub2129 avatar Sep 13 '24 14:09 DekuSkrub2129