NuGet.Client icon indicating copy to clipboard operation
NuGet.Client copied to clipboard

Fix all occurences of IDE0055 code style formatting rule violations

Open 4creators opened this issue 1 year ago • 1 comments

… fix local repo and source build builds

Bug

Fixes: Build failures caused by code style violations raising IDE0055 warning described in issue #13714

Description

PR Checklist

  • [x] Meaningful title, helpful description and a linked NuGet/Home issue
  • [ ] Added tests
  • [ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

4creators avatar Aug 16 '24 10:08 4creators

I am unable to reproduce the build errors reported in https://github.com/NuGet/Home/issues/13714 locally. We fail builds on our CI if there are formatting errors in the code. So far, both local (on CLI and VS) and CI builds haven't complained about these formatting issues. Please let me know if I am missing something while trying to reproduce these failures locally.

❯ ./build.ps1 -Configuration Release -SkipUnitTest
[16:23:04 +0]   ============================================================
[16:23:04 +0]   Build started at 08/22/2024 23:23:04
[16:23:04 +0]   [BEGIN] Cleaning artifacts
[16:23:04 +0]   Cleaning the Artifacts folder
[16:23:09 +4]   [DONE +00:00:04] Cleaning artifacts
[16:23:09 +0]   [BEGIN] Running Restore
[16:23:09 +0]   . "msbuild.exe" build\build.proj /t:RestoreVS /p:Configuration=Release /p:ReleaseLabel=zlocal /p:IncludeApex=False /v:m /m
MSBuild version 17.12.0-preview-24415-04+f422d8d7d for .NET Framework

  Restoring
  Determining projects to restore...
  // restore logs
  All projects are up-to-date for restore.

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:10.64
[16:23:19 +11]  [DONE +00:00:10] Running Restore
[16:23:19 +0]   [BEGIN] Running Build
[16:23:19 +0]   . "msbuild.exe" build\build.proj /t:BuildVS;Pack /p:Configuration=Release /p:ReleaseLabel=zlocal /p:IncludeApex=False /v:m /m
MSBuild version 17.12.0-preview-24415-04+f422d8d7d for .NET Framework
Building
// build logs

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:04:26.17
[16:27:46 +266] [DONE +00:04:26] Running Build
WARNING: [16:27:46 +0] [SKIP] Creating the EndToEnd test package
WARNING: [16:27:46 +0] [SKIP] Running Restore RTM
WARNING: [16:27:46 +0] [SKIP] Packing RTM
[16:27:46 +0]   Build #0 ended at 08/22/2024 23:27:46
[16:27:46 +0]   Time elapsed 00:04:41
[16:27:46 +0]   ============================================================

kartheekp-ms avatar Aug 22 '24 23:08 kartheekp-ms

Team triage: We haven't been able to reproduce this in local and our CI, please feel free to reopen the issue if we missed something while trying to reproduce

martinrrm avatar Oct 09 '24 22:10 martinrrm