Plasma-Overdose icon indicating copy to clipboard operation
Plasma-Overdose copied to clipboard

fix(#2 #3): fixed aurorae margins and more

Open olivertzeng opened this issue 1 year ago • 12 comments

olivertzeng avatar Jan 03 '25 13:01 olivertzeng

the dependencies inside the json doesn't actually really work/is broken somehow, better to just let the user install them themselves ig

olivertzeng avatar Jan 03 '25 13:01 olivertzeng

请问何时准备更新新版本?在KDE Store更新这么多插件还是稍微有点费力的流程,若完全准备好更新的话请在PR里面留Comment

Notify-ctrl avatar Jan 23 '25 11:01 Notify-ctrl

你要学会多用软链接,不要把相同的文件复制很多次,这样会让repo体积暴涨。以及Splash.png的体积实在太大了

我會 ln -sf 目標 檔案

但是說實在話我不知道要連結什麼 我也不太習慣這麼做 對了 Splash.png檔案過大會怎麼樣嗎 因為說實在話上一張的畫質實在是太低了

olivertzeng avatar Jan 23 '25 11:01 olivertzeng

我好像知道了你應該是指在sounds內的檔案吧 我同意我現在趕快修改

olivertzeng avatar Jan 23 '25 11:01 olivertzeng

@Notify-ctrl c0c026f

olivertzeng avatar Jan 23 '25 12:01 olivertzeng

你要学会多用软链接,不要把相同的文件复制很多次,这样会让repo体积暴涨。以及Splash.png的体积实在太大了

我會 ln -sf 目標 檔案

但是說實在話我不知道要連結什麼 我也不太習慣這麼做 對了 Splash.png檔案過大會怎麼樣嗎 因為說實在話上一張的畫質實在是太低了

用软链接链接一下重复的文件就好了,比如那么多音频文件以及那个splash.png也有重复的情形

Notify-ctrl avatar Jan 24 '25 01:01 Notify-ctrl

@Notify-ctrl c0c026f

OK 辛苦了👍

Notify-ctrl avatar Jan 24 '25 01:01 Notify-ctrl

@Notify-ctrl c0c026f

OK 辛苦了👍

我還幫你加入 identical.sh,可以自動檢查哪些檔案需要連結 他會假查哪兩個檔案的 md5 checksum 是 相同的,然後你就可以開始連結了

olivertzeng avatar Jan 24 '25 01:01 olivertzeng

#7 also solved

olivertzeng avatar Jan 24 '25 07:01 olivertzeng

@Notify-ctrl I've noticed https://github.com/Notify-ctrl/Plasma-Overdose/compare/master...yuna0x0:Plasma-Overdose:master and thought to myself: should we just replace the original x1.0 aurorae theme with x1.5 and ditch x1.0

because i don't know why you would want two identical themes

or is it identical?

olivertzeng avatar Jan 24 '25 08:01 olivertzeng

@Notify-ctrl I've noticed master...yuna0x0:Plasma-Overdose:master and thought to myself: should we just replace the original x1.0 aurorae theme with x1.5 and ditch x1.0

because i don't know why you would want two identical themes

or is it identical?

这个我有点忘了 好像就是某些间距之类的数值有差别吧 图都是同一套好像

Notify-ctrl avatar Jan 25 '25 11:01 Notify-ctrl

@Notify-ctrl I've noticed master...yuna0x0:Plasma-Overdose:master and thought to myself: should we just replace the original x1.0 aurorae theme with x1.5 and ditch x1.0

because i don't know why you would want two identical themes

or is it identical?

这个我有点忘了 好像就是某些间距之类的数值有差别吧 图都是同一套好像

Yeah let's just keep it for now

Are there any suggestions for my pr?

olivertzeng avatar Jan 25 '25 11:01 olivertzeng

@Notify-ctrl are there any updates on when to merge this pr? It's been a while

olivertzeng avatar Mar 15 '25 13:03 olivertzeng

Thanks @Notify-ctrl

olivertzeng avatar Mar 15 '25 13:03 olivertzeng