melia
melia copied to clipboard
Fix attack type multiplier
This PR removes the conversion of attack type according to the attacker's right handed weapon.
Why this conversion is incorrect:
- As stated in the comment, it doesn't take in consideration the left hand weapon of the attacker. Off-hand basic attacks are already skills and have the correct attack type (i.e. a dagger attack has aries/piercing type). This conversion was wrongfully switching their attack types to the right handed weapon's attack type.
- Magic skills (i.e. energy bolt) have "Magic" attackType. This conversion was wrongfully converting the energy bolt to "Strike" due to a staff/rod weapon being "Strike" attackType.
- The game inherently does not convert attack types according to attacker's weapons. A swordsman's Bash skill deals "Slash" type damage regardless if player is equipped with a sword, spear or mace.