convert tsfeatures lib to nbdev framework
This pr uses the nbdev framework to build the tsfeatures lib. All old files are copied 1-on-1, eager to get some feedback on this
Hey @jope35, thanks for the initiative, we support this. Just some requests before we review this more thoroughly:
- Please restore the files under the
.githubfolder. - Please restore the .gitignore, LICENSE and setup.py files.
- Please remove the
pre-commit-config.yamland.ruff.toml. These can be added in a later PR so that we can focus on those changes specifically. - Please restore and move the
compare_with_r.pyfile to ascriptsfolder or similar.
@jmoralez thanks for the quick scan. will incorporate the changes 👍
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Some more requests:
- Please update the settings.ini file with the current settings in setup.py, e.g. version should be 0.4.5. For the author and other stuff you can refer to this file.
- Please update the setup.py file. I believe you can copy this one
- Please remove the ordering from the notebooks (the number prefixes)
Thanks for the updates. Can you please merge tsfeatures_core.ipynb with features.ipynb? They both should be the same notebook that exports the tsfeatures module.
Merge tsfeatures_core.ipynb with features.ipynb, the result is exported to tsfeatures.