tsfeatures icon indicating copy to clipboard operation
tsfeatures copied to clipboard

convert tsfeatures lib to nbdev framework

Open jope35 opened this issue 2 years ago • 6 comments

This pr uses the nbdev framework to build the tsfeatures lib. All old files are copied 1-on-1, eager to get some feedback on this

jope35 avatar Jan 04 '24 15:01 jope35

Hey @jope35, thanks for the initiative, we support this. Just some requests before we review this more thoroughly:

  • Please restore the files under the .github folder.
  • Please restore the .gitignore, LICENSE and setup.py files.
  • Please remove the pre-commit-config.yaml and .ruff.toml. These can be added in a later PR so that we can focus on those changes specifically.
  • Please restore and move the compare_with_r.py file to a scripts folder or similar.

jmoralez avatar Jan 09 '24 19:01 jmoralez

@jmoralez thanks for the quick scan. will incorporate the changes 👍

jope35 avatar Jan 10 '24 16:01 jope35

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Some more requests:

  • Please update the settings.ini file with the current settings in setup.py, e.g. version should be 0.4.5. For the author and other stuff you can refer to this file.
  • Please update the setup.py file. I believe you can copy this one
  • Please remove the ordering from the notebooks (the number prefixes)

jmoralez avatar Jan 16 '24 23:01 jmoralez

Thanks for the updates. Can you please merge tsfeatures_core.ipynb with features.ipynb? They both should be the same notebook that exports the tsfeatures module.

jmoralez avatar Jan 30 '24 16:01 jmoralez

Merge tsfeatures_core.ipynb with features.ipynb, the result is exported to tsfeatures.

jope35 avatar Feb 04 '24 18:02 jope35