nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

Added initial release for clipse | v0.0.6 | I am looking to grow and …

Open savedra1 opened this issue 2 years ago • 1 comments

…maintain this project for a long time.

Description of changes

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [x] aarch64-linux
    • [x] x86_64-darwin
    • [x] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [x] sandbox = true
  • [x] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

savedra1 avatar Mar 05 '24 16:03 savedra1

Please look into the contribution guidelines, especially https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions and https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy.

leona-ya avatar Mar 05 '24 22:03 leona-ya

Please look into the contribution guidelines, especially https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions and https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy.

Thank you for your response. I have updated my commit message format and updated the dir structure to the following hierarchy:

pkgs
└── by-name
   ├── so
   ┊  ├── some-package
      ┊  └── package.nix

Please let me know if there's anything else I should do, cheers!

savedra1 avatar Mar 06 '24 08:03 savedra1

It looks like you accidentally mass-pinged a bunch of people, which are now subscribed and getting notifications for everything in this pull request. Unfortunately, they cannot be automatically unsubscribed from the issue (removing review request does not unsubscribe), therefore development cannot continue in this pull request anymore.

Please create a new pull request, link back to this one and ping the people actually involved in here over there. For the next time, remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue.

In order to avoid this in the future, there are instructions for how to properly rebase between branches in our contribution guidelines. Setting your pull request to draft prior to rebasing is strongly recommended. In draft status, you can preview the list of people that are about to be requested for review, which allows you to sidestep this issue. This is not a bulletproof method, though, as OfBorg still does review requests even on draft PRs.

drupol avatar Mar 06 '24 09:03 drupol