nix.dev icon indicating copy to clipboard operation
nix.dev copied to clipboard
verified publisher icon NixOS

Minor improvements

Open pdietl opened this issue 1 year ago • 3 comments

Add more error checking to the map and geocode script Rename map to map.sh and geocode to geocode.sh in hopes that when downloading, Google Chrome doesn't automatically add a .txt extension.

The default zoom of 2 results in the center option not showing anything different. So, we change the default zoom to 10.

We also clear up the fact that using an option type of nullOr <blah> does not set a default value of null for you.

pdietl avatar Apr 20 '24 22:04 pdietl

Nice! Though Git doesn't detect the files as having been renamed. To fix this, could you split this into at least two commits, the first one that just renames the files, the second changing them? That should make reviewing easier :)

infinisil avatar May 13 '24 16:05 infinisil

@infinisil I did the history rewrite.

fricklerhandwerk avatar May 14 '24 20:05 fricklerhandwerk

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-05-14-documentation-team-meeting-notes-126/45431/1

nixos-discourse avatar May 14 '24 21:05 nixos-discourse