CoreComponents icon indicating copy to clipboard operation
CoreComponents copied to clipboard

WrappingParameterizedRunner debug code causes failure on Windows

Open Nava2 opened this issue 8 years ago • 5 comments

This debug code:

// WrappingParameterizedRunner.java L313
/* ** DEBUG export class to /tmp/x.class ** */
		try {
			FileOutputStream fos = new FileOutputStream("/tmp/x.class");
			fos.write(clazzBytes);
			fos.close();
		} catch (Exception e1) {
			e1.printStackTrace();
		}
		/* ** /DEBUG ** */

throws on Windows immediately, /tmp doesn't exist. Could be replaced with the Files.createTempFile() or similar.

Nava2 avatar Mar 24 '17 15:03 Nava2

*blush* It should just be removed. It was used during development.

xkr47 avatar Mar 27 '17 07:03 xkr47

Actually it was fixed a year ago but no new release has been made. Maybe time for one then!

xkr47 avatar Mar 27 '17 07:03 xkr47

I had a feeling.. Once JUnit 5 stabilizes their parameterized testing, hopefully it means this library isn't needed anymore and no more maintenance. 🙌

Nava2 avatar Mar 27 '17 11:03 Nava2

Any Plan to fix this!?

IRasmivan avatar Jul 03 '17 20:07 IRasmivan

hello,

any chance for a release on this correction (fe4d2d93285d31b0a5850dc6ee741c05348f51ee) (thx xkr47) ? this lib looks nice but can't run it on local due to this issue.

Had to fix it myself bu overriding WrappingParameterizedRunner but need to add ParameterizedSuiteBuilder, DescriptionMappingRunNotifierProxy, ClassLoaderInjector sources too, it s not clean in my project :(

xanyook avatar Jun 11 '18 15:06 xanyook