pam-MySQL icon indicating copy to clipboard operation
pam-MySQL copied to clipboard

my_make_scrambled_password() is not part of the MySQL API

Open wferi opened this issue 9 years ago • 4 comments

The my_make_scrambled_password() function is exported by the MySQL client libraries "to provide backwards compatibility with applications that for legacy reasons use undocumented symbols". It isn't declared in the client header files. See https://bugs.mysql.com/bug.php?id=80974 and https://github.com/jedisct1/pure-ftpd/issues/37 for background. A reimplementation is available as well.

wferi avatar Nov 16 '16 09:11 wferi

This should now be fixed in the 0.8.x branch. Please test if you're able.

NigelCunningham avatar Mar 23 '17 10:03 NigelCunningham

Hi again.

I'm thinking of just releasing 0.8.1. Any feedback on that idea? (I've received "It works for me" for the latest version with the autoconf changes).

Regards,

Nigel

NigelCunningham avatar Apr 06 '17 12:04 NigelCunningham

Hi, I put some comments on commit 662940f5ab950ea77eccd7a4e30d648e831f5b5a 10 days ago, and still find them worth discussing. They mostly concern the generic use/presence of the embedded MD5 and SHA1 implementations. The my_make_scrambled_password() routine does not use MD5 at all, but the other code parts could, when no other implementation is available. Unless you make it a hard requirement, but then there's no use embedding them...

wferi avatar Apr 06 '17 19:04 wferi

Morning.

Oh, I'm sorry. I'll look again.

Thanks!

Nigel

NigelCunningham avatar Apr 06 '17 21:04 NigelCunningham