Tagger icon indicating copy to clipboard operation
Tagger copied to clipboard

tagger doesn't work with musicbrainz (or it seems so)

Open legacychimera247 opened this issue 3 years ago • 8 comments

everytime i try to use the musicbrainz feature tagger seems to search for something and then just does nothing, maybe a confirmation doing something would be good? (if it's actually doing something)

legacychimera247 avatar Jun 20 '22 15:06 legacychimera247

The library used to access musicbrainz, libmusicbrainz5, seems to be a little outdated for accessing musicbrainz, I have noticed. I will be looking for either another music database or a better way to accessing musicbrainz to also complete #18.

nlogozzo avatar Jun 20 '22 15:06 nlogozzo

As of now, Tagger will only get the year, album, and album artist from musicbrainz if available.

nlogozzo avatar Jun 20 '22 16:06 nlogozzo

by the way, don't think you can add chromaprint support for tagging song by listening them, right?

legacychimera247 avatar Jun 21 '22 00:06 legacychimera247

It looks like a C++ library so I should be able to include it. That'll make it a lot easier with MusicBrainz searching as well.

nlogozzo avatar Jun 21 '22 00:06 nlogozzo

by the way, so opened a flac record with picard and had a look at the tags, withouth changing anything, then opened the same record with tagger, downloaded the data from musicbrainz then clicked apply, after that i launched picard, to see tags were exactly the same as before, are you sure the function is actually working? :)

legacychimera247 avatar Jun 28 '22 14:06 legacychimera247

I've decided to scrap the MusicBrainz feature using libmusicbrainz5 completely in the next version, until I can find a more suitable library for this task. The API used by Picard seems to not be the same as the public libmusicbrainz5 API available to outside developers.

nlogozzo avatar Aug 03 '22 03:08 nlogozzo

oh ok, that's a shame, weird anyway cause ex-falso is working almost the same way as picard...

legacychimera247 avatar Aug 04 '22 09:08 legacychimera247

Those softwares are written in python with those APIs for MusicBrainz easily available and more up to date than libmusicbrainz5 for C++. I will have to take a look at the python library used by those programs and probably have to port it over to C++, which may take some time.

nlogozzo avatar Aug 04 '22 15:08 nlogozzo

Added chromaprint support: https://github.com/nlogozzo/NickvisionTagger/releases/tag/2022.9.1

nlogozzo avatar Sep 25 '22 04:09 nlogozzo

Now that chromaprint is in place, expect MusicBrainz search for the next release.

nlogozzo avatar Sep 25 '22 04:09 nlogozzo

https://github.com/nlogozzo/NickvisionTagger/releases/tag/2022.9.2-beta1

nlogozzo avatar Sep 29 '22 02:09 nlogozzo

https://github.com/nlogozzo/NickvisionTagger/releases/tag/2022.9.2

nlogozzo avatar Sep 29 '22 15:09 nlogozzo