nice-node icon indicating copy to clipboard operation
nice-node copied to clipboard

feat: Add default node storage location preference

Open kalidatony opened this issue 11 months ago • 10 comments

  • Introduced new storage preferences section in app settings
  • Added ability to set and change default node storage location
  • Implemented storage location selection with free space information
  • Updated translations and preload interfaces to support new feature

kalidatony avatar Feb 27 '25 19:02 kalidatony

Deploy Preview for nndesign ready!

Name Link
Latest commit acae7db5d2d0ee3c311fe2c3a19b6e0792c0257a
Latest deploy log https://app.netlify.com/sites/nndesign/deploys/67c30faebfb53b0008a08e9e
Deploy Preview https://deploy-preview-690--nndesign.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 27 '25 19:02 netlify[bot]

hey @kalidatony thanks!

Just took a quick look at the diffs. It looks like the first part of this is done, UI and saving the setting. Second part would be using this as the default storage path instead of the previous default (I believe its something like electron.appStorage).

Not a must, but we could do a permissions check on the directory path that the user chooses to make sure they have write permissions.

If you don't mind, see if installing biomejs in cursor/vscode, the tool we use for formatting, to see if that prevents things like single quote to double quote diffs.

jgresham avatar Feb 28 '25 22:02 jgresham

@jgresham I have added the changes, Please check

kalidatony avatar Mar 01 '25 13:03 kalidatony

@jgresham I have added the changes, Please check

excellent. I will test it out across different machines/OSs over the next few days

jgresham avatar Mar 01 '25 16:03 jgresham

Hey I didn't forget about this, I've just been away from my hardware for testing!

jgresham avatar Mar 10 '25 19:03 jgresham

Hey I didn't forget about this, I've just been away from my hardware for testing!

it's alright man. Thank you

kalidatony avatar Mar 11 '25 20:03 kalidatony

Hi @jgresham . Hope you are well. Have you been able to check it out?

kalidatony avatar Mar 19 '25 11:03 kalidatony

@kalidatony can you revert the changes from ' to ’

jgresham avatar Apr 24 '25 17:04 jgresham

@kalidatony and revert the ' to " for the import lines

jgresham avatar Apr 24 '25 17:04 jgresham

@kalidatony I tested this on mac and windows and it doesnt work

jgresham avatar Apr 24 '25 17:04 jgresham