nice-node icon indicating copy to clipboard operation
nice-node copied to clipboard

feat: system tray custom menu & podman modal

Open corn-potage opened this issue 1 year ago • 6 comments

  • added new podman modal to handle various podman status cases from sidebar and
  • added custom menu to handle node statuses
  • clicking on node opens the correct node in the app
  • quit menu opens dialog
  • fixed various existing podman related bugs
  • added warning on requirements step for users who currently use Mac OS lower than 13.0.0, as virtualization doesn't work for lower versions

will need to be tested on Windows and Linux

Notes:

  • currently not a react component but javascript creating html nodes in the custom window; had difficulty and will need more time to figure that out
  • couldn't get colored notification icon to work
  • need more time to figure out a better way to handle granular node statuses such as "Initializing", "Syncing", etc so it can be used the same way in Tray, NodePackageScreen, etc.

#526

corn-potage avatar Jun 03 '24 01:06 corn-potage

Deploy Preview for nndesign ready!

Name Link
Latest commit 504ed766c2c7a66bc60073b1f9680d429cc55955
Latest deploy log https://app.netlify.com/sites/nndesign/deploys/66a970ccb9545f0009f5e89a
Deploy Preview https://deploy-preview-597--nndesign.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 03 '24 01:06 netlify[bot]

Have any screenshots?

Clicking on this add node just shows the "Podman is a required component for NiceNode..." modal. Clicking on add node in sidebar works though.

Screenshot 2024-06-03 at 1 33 28 PM

with npm start the tray shows the chrome dev tools, not sure if we can disable this somehow. I can't recall how devtools settings work Screenshot 2024-06-03 at 1 35 06 PM

jgresham avatar Jun 03 '24 17:06 jgresham

Looking great! and themed! Screenshot 2024-06-03 at 2 53 46 PM

jgresham avatar Jun 03 '24 18:06 jgresham

@jgresham Ahh I added podman modal to Add Node in the beginning for debug purposes and forgot to revert back. Will fix 👍

I have the following for the tray:

if (process.env.NODE_ENV === 'development') {
    trayWindow?.webContents.openDevTools();
  }

should I remove this entirely?

Do you happen to have Windows? Would you be able to see if the custom menu shows up fine in the right position? I'll need to check on Linux too..

corn-potage avatar Jun 03 '24 20:06 corn-potage

Nice set of features and fixes in here!

jgresham avatar Jun 03 '24 21:06 jgresham

todo for me is to stop all nodes and podman machine before the "full quit" from the tray icon. right now this isn't true Screenshot 2024-06-05 at 10 14 07 AM

jgresham avatar Jun 05 '24 14:06 jgresham