bug: unexpected logging messages from py-sdk

Open onikonychev opened this issue 3 years ago • 1 comments

Here and there in liquidator and heart-monitor some unexpected py-sdk messages are appearinng:

12:06:41|DEBUG|_handle_txs| Failed parsing events log: failed to execute message; message index: 0: 0unibi is smaller than 100000000unibi: insufficient funds. Expecting value: line 1 column 1 (char 0)

Need to make sdk and app logging consistent and have an ability to turn off DEBUG if it's not intentionally on.

Nov 08 '22 12:11 onikonychev

What I'd do for this behavior is use argparse from the standard library and add a flag for --log or --loglevel that adjusts the logging.basicConfig. That way, you can customize whether you want to see the DEBUG, INFO, and WARNING statements on different runs.

Another option could be that we add an argument, log_level to the constructor for the nibiru.Sdk object. Then, you'd be able to adjust it at the program level when you initialize the Sdk.

I'm in favor of implementing both of these, tbh

Dec 09 '22 05:12 Unique-Divine