proxy_set_header Host $http_host setting does not take effect

[chung1912]

Checklist

• Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
  • Yes
• Are you sure you're not using someone else's docker image?
  • Yes
• Have you searched for similar issues (both open and closed)?
  • Yes

Describe the bug

Nginx Proxy Manager Version

2.11.3

To Reproduce Steps to reproduce the behavior: After proxy_set_header Host $http_host is set, it will be placed at the front of "location", resulting in the configuration not being effective. For details, please see the figure My configuration on the page is as follows: The configuration information seen in conf is as follows: As shown in the figure, since proxy_set_header Host $host; is generated by default and is after proxy_set_header Host $http_host;, proxy_set_header Host $host; will take effect.

Expected behavior

Custom configuration should be placed at the end, not at the beginning, to ensure that the custom configuration can take effect normally, as shown in the following figure

Operating System

Additional context

[eliasmainetti]

Same problem

[swensorm]

This seems to be a very very common issue with many open tickets. The root of the issue appears to be using $host instead of $http_host in the root proxy.conf and _location.conf for any of us unfortunate souls not running NPM on default browser ports 80/443, but I don't know if there are any breaking effects of having that change globally. For many downstream applications it does not matter but for some (e.g. Kavita, Home Assistant) not everything works. Hoping this can be addressed once and for all 🙏

[whc2001]

There is a problematic commit https://github.com/NginxProxyManager/nginx-proxy-manager/commit/280bac8b430a3465f1fbc4d7e8d94e148ad740e7 which breaks the entire custom directions setting. No one seem to care about fixing it at all.

Update: This is more harsh than I imagined. Seems like there should be only one proxy_set_header Host so simply changing the template would not work. Need some more logic to make sure either proxy_set_header Host $host or proxy_set_header Host $http_host only appear once.

[wakawakaaa]

same issue. nginx proxy manager is broken v2.12.1

Error "Could not delete file:" occurs only when setting ssl for a domain in the gui.

[information-security]

This is a blocking bug that makes the custom configurations almost to totally useless. BTW, This is a duplicate of #3980.

[github-actions[bot]]

Issue is now considered stale. If you want to keep it open, please comment :+1: