nginx-proxy-manager
nginx-proxy-manager copied to clipboard
📚 add arabic local for V3
Hi there !
thanks for all work, I hope you accept this RP
Looks good and thanks for contributing here. Just that one comment from me.
Since this is an unreleased-dev branch it's not greatly documented, however you can ensure that the language files are happy by running the following:
cd frontend
yarn install
yarn check-locales
The CI will run this and fail the PR if this script isn't happy.
11:53:15 $ /app/frontend/node_modules/.bin/eslint src
11:53:18
11:53:18 /app/frontend/src/locale/IntlProvider.tsx
11:53:18 6:1 error `./lang/ar.json` import should occur before import of `./lang/de.json` import/order
11:53:18
11:53:18 ✖ 1 problem (1 error, 0 warnings)
11:53:18 1 error and 0 warnings potentially fixable with the `--fix` option.
CI Error:
[1;34m❯ [1;36mInstalling Frontend deps ...[0m
Unable to find image 'node:16' locally
16: Pulling from library/node
d8a6bce2a40c: Pulling fs layer
b4fc05781c9a: Pulling fs layer
4efc3ea86e67: Pulling fs layer
47452733a7c0: Pulling fs layer
6f68a3641163: Pulling fs layer
eb0699081d5a: Pulling fs layer
083b2e959d70: Pulling fs layer
b60b3eeedcbe: Pulling fs layer
9cc430d8007f: Pulling fs layer
b60b3eeedcbe: Waiting
eb0699081d5a: Waiting
9cc430d8007f: Waiting
083b2e959d70: Waiting
47452733a7c0: Waiting
6f68a3641163: Waiting
4efc3ea86e67: Verifying Checksum
4efc3ea86e67: Download complete
b4fc05781c9a: Verifying Checksum
b4fc05781c9a: Download complete
d8a6bce2a40c: Verifying Checksum
d8a6bce2a40c: Download complete
eb0699081d5a: Download complete
d8a6bce2a40c: Pull complete
b4fc05781c9a: Pull complete
4efc3ea86e67: Pull complete
083b2e959d70: Verifying Checksum
083b2e959d70: Download complete
b60b3eeedcbe: Download complete
47452733a7c0: Verifying Checksum
47452733a7c0: Download complete
9cc430d8007f: Download complete
47452733a7c0: Pull complete
6f68a3641163: Verifying Checksum
6f68a3641163: Download complete
6f68a3641163: Pull complete
eb0699081d5a: Pull complete
083b2e959d70: Pull complete
b60b3eeedcbe: Pull complete
9cc430d8007f: Pull complete
Digest: sha256:8ef06c513538040a988ac7731afa8ad8b1135cfe5d8b6ad78489d80c6f6c0137
Status: Downloaded newer image for node:16
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > [email protected]" has unmet peer dependency "@chakra-ui/form-control@^2.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/icon@^3.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/layout@^2.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/media-query@^3.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/menu@^2.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/spinner@^2.0.0".
warning " > [email protected]" has unmet peer dependency "@chakra-ui/system@^2.0.0".
warning " > [email protected]" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning " > [email protected]" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning " > [email protected]" has incorrect peer dependency "eslint@^6.0.0 || ^7.0.0".
warning " > [email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning " > [email protected]" has unmet peer dependency "jest@^25.1 || ^26 || ^27 || ^28".
[4/4] Building fresh packages...
Done in 43.75s.
[1;34m❯ [1;36mChecking locales ...[0m
[33mWARN: `de` does not contain item: `acmesh-property.access-key-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.account-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.api-key`[0m
[33mWARN: `de` does not contain item: `acmesh-property.api-url`[0m
[33mWARN: `de` does not contain item: `acmesh-property.app-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.auth-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.base-url`[0m
[33mWARN: `de` does not contain item: `acmesh-property.client-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.client-secret`[0m
[33mWARN: `de` does not contain item: `acmesh-property.context`[0m
[33mWARN: `de` does not contain item: `acmesh-property.credentials`[0m
[33mWARN: `de` does not contain item: `acmesh-property.customer`[0m
[33mWARN: `de` does not contain item: `acmesh-property.email`[0m
[33mWARN: `de` does not contain item: `acmesh-property.id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.insecure`[0m
[33mWARN: `de` does not contain item: `acmesh-property.key`[0m
[33mWARN: `de` does not contain item: `acmesh-property.oauth-token`[0m
[33mWARN: `de` does not contain item: `acmesh-property.otp-secret`[0m
[33mWARN: `de` does not contain item: `acmesh-property.password`[0m
[33mWARN: `de` does not contain item: `acmesh-property.secret`[0m
[33mWARN: `de` does not contain item: `acmesh-property.secret-access-key`[0m
[33mWARN: `de` does not contain item: `acmesh-property.server`[0m
[33mWARN: `de` does not contain item: `acmesh-property.server-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.slow-rate`[0m
[33mWARN: `de` does not contain item: `acmesh-property.sub-auth-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.subdomain`[0m
[33mWARN: `de` does not contain item: `acmesh-property.subscription-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.tenant-id`[0m
[33mWARN: `de` does not contain item: `acmesh-property.token`[0m
[33mWARN: `de` does not contain item: `acmesh-property.ttl`[0m
[33mWARN: `de` does not contain item: `acmesh-property.url`[0m
[33mWARN: `de` does not contain item: `acmesh-property.user`[0m
[33mWARN: `de` does not contain item: `acmesh-property.username`[0m
[33mWARN: `de` does not contain item: `acmesh-property.zone-id`[0m
[33mWARN: `de` does not contain item: `capability.access-lists.manage`[0m
[33mWARN: `de` does not contain item: `capability.access-lists.view`[0m
[33mWARN: `de` does not contain item: `capability.audit-log.view`[0m
[33mWARN: `de` does not contain item: `capability.certificate-authorities.manage`[0m
[33mWARN: `de` does not contain item: `capability.certificate-authorities.view`[0m
[33mWARN: `de` does not contain item: `capability.certificates.manage`[0m
[33mWARN: `de` does not contain item: `capability.certificates.view`[0m
[33mWARN: `de` does not contain item: `capability.dns-providers.manage`[0m
[33mWARN: `de` does not contain item: `capability.dns-providers.view`[0m
[33mWARN: `de` does not contain item: `capability.hosts.manage`[0m
[33mWARN: `de` does not contain item: `capability.nginx-templates.manage`[0m
[33mWARN: `de` does not contain item: `capability.nginx-templates.view`[0m
[33mWARN: `de` does not contain item: `capability.settings.manage`[0m
[33mWARN: `de` does not contain item: `status.provided`[0m
[33mWARN: `de` does not contain item: `status.requesting`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.access-key-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.account-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.api-key`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.api-url`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.app-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.auth-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.base-url`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.client-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.client-secret`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.context`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.credentials`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.customer`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.email`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.insecure`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.key`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.oauth-token`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.otp-secret`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.password`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.secret`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.secret-access-key`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.server`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.server-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.slow-rate`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.sub-auth-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.subdomain`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.subscription-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.tenant-id`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.token`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.ttl`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.url`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.user`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.username`[0m
[33mWARN: `fa` does not contain item: `acmesh-property.zone-id`[0m
[33mWARN: `fa` does not contain item: `capability.access-lists.manage`[0m
[33mWARN: `fa` does not contain item: `capability.access-lists.view`[0m
[33mWARN: `fa` does not contain item: `capability.audit-log.view`[0m
[33mWARN: `fa` does not contain item: `capability.certificate-authorities.manage`[0m
[33mWARN: `fa` does not contain item: `capability.certificate-authorities.view`[0m
[33mWARN: `fa` does not contain item: `capability.certificates.manage`[0m
[33mWARN: `fa` does not contain item: `capability.certificates.view`[0m
[33mWARN: `fa` does not contain item: `capability.dns-providers.manage`[0m
[33mWARN: `fa` does not contain item: `capability.dns-providers.view`[0m
[33mWARN: `fa` does not contain item: `capability.hosts.manage`[0m
[33mWARN: `fa` does not contain item: `capability.nginx-templates.manage`[0m
[33mWARN: `fa` does not contain item: `capability.nginx-templates.view`[0m
[33mWARN: `fa` does not contain item: `capability.settings.manage`[0m
[33mWARN: `fa` does not contain item: `status.provided`[0m
[32mLocale check passed[0m
[1;34m❯ [1;36mCompiling locales ...[0m
yarn run v1.22.19
$ formatjs compile-folder src/locale/src src/locale/lang
Done in 0.19s.
[1;34m❯ [1;36mRunning eslint ...[0m
yarn run v1.22.19
$ /app/frontend/node_modules/.bin/eslint src
/app/frontend/src/locale/IntlProvider.tsx
1:1 error There should be at least one empty line between import groups import/order
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
PR is now considered stale. If you want to keep it open, please comment :+1: