pynwb icon indicating copy to clipboard operation
pynwb copied to clipboard

Add dataset to store list of software that produced a file

Open stephprince opened this issue 1 year ago • 2 comments

Motivation

Related pynwb changes for the proposed nwb-schema PR for provenance information.

TODO

  • [ ] Update to merge into nwb_schema_2.8.0 branch when reviewed

How to test the behavior?

Checklist

  • [ ] Did you update CHANGELOG.md with your changes?
  • [x] Have you checked our Contributing document?
  • [x] Have you ensured the PR clearly describes the problem and the solution?
  • [x] Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • [x] Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • [x] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

stephprince avatar Jun 27 '24 17:06 stephprince

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.30%. Comparing base (dc98e84) to head (0b3be53).

:exclamation: There is a different number of reports uploaded between BASE (dc98e84) and HEAD (0b3be53). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dc98e84) HEAD (0b3be53)
integration 4 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb_schema_2.8.0    #1924      +/-   ##
====================================================
- Coverage             91.85%   83.30%   -8.56%     
====================================================
  Files                    27       27              
  Lines                  2689     2689              
  Branches                701      701              
====================================================
- Hits                   2470     2240     -230     
- Misses                  145      352     +207     
- Partials                 74       97      +23     
Flag Coverage Δ
integration ?
unit 83.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 17:06 codecov[bot]

@rly with the support for writing multidimensional string arrays merged into hdmf, this should be ready to be reviewed.

I think all of the failing tests are from the other 2.8.0 schema changes (SpatialSeries.bounds and ragged Units.waveform_mean/sd)

stephprince avatar Sep 19 '24 17:09 stephprince