python-neo icon indicating copy to clipboard operation
python-neo copied to clipboard

Update micromed for sampling issue

Open zm711 opened this issue 8 months ago • 7 comments

See #1696.

Testing to see if there is something wrong with class based approach @samuelgarcia maybe we could discuss this.

zm711 avatar May 07 '25 16:05 zm711

@theairbend3r could you test this PR? I just want to see what happens if we try removing the class approach we used before (ie your suggestion and what wonambi was doing). Our tests are passing for micromed so this could be a fix we make if it works for you :)

zm711 avatar May 07 '25 16:05 zm711

Tried this out but I still get the same ZeroDivisionError unfortunately

theairbend3r avatar May 08 '25 13:05 theairbend3r

Okay, I was hoping this would be the easy fix, but when I have time I'll try to read wonami more to see if they are doing some header parsing that we skip that could better account for different versions of the file format.

zm711 avatar May 08 '25 15:05 zm711

Sounds good! Thanks for all your efforts, really appreciate it! :)

theairbend3r avatar May 09 '25 11:05 theairbend3r

@zm711 Potentially this request will provide test files for debugging here: https://github.com/wonambi-python/wonambi/issues/42

JuliaSprenger avatar Jul 07 '25 15:07 JuliaSprenger

@theairbend3r,

just wanted to give you a small update. We discussed this at our maintenance meeting and our hope is to try to work on this for the next version of neo. As you can see from the link we put out the feelers to wonambi to see if they might have a test file that can reproduce the error so we can fix it.

zm711 avatar Jul 09 '25 12:07 zm711

Appreciate the update @zm711! Hopefully, the test files help! 🤞

theairbend3r avatar Jul 11 '25 09:07 theairbend3r