sedge icon indicating copy to clipboard operation
sedge copied to clipboard

Lido Tier 1 Integration NO data

Open khalifaa55 opened this issue 1 year ago • 1 comments

Changes:

  • Add Lido CSM integration

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [x] Yes
  • [ ] No

khalifaa55 avatar Jul 23 '24 10:07 khalifaa55

Codecov Report

Attention: Patch coverage is 97.82609% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.26%. Comparing base (aef5ceb) to head (cb7f294).

Files Patch % Lines
internal/lido/contracts/csaccounting/bonds.go 92.85% 1 Missing and 1 partial :warning:
internal/lido/contracts/contract_setup.go 93.33% 1 Missing :warning:
internal/lido/contracts/csmodule/nodeOperator.go 97.77% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #401       +/-   ##
============================================
+ Coverage    76.92%   87.26%   +10.33%     
============================================
  Files           86       91        +5     
  Lines         4807     4412      -395     
============================================
+ Hits          3698     3850      +152     
+ Misses        1015      467      -548     
- Partials        94       95        +1     
Flag Coverage Δ
unittests 87.26% <97.82%> (+10.33%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 23 '24 10:07 codecov-commenter

@AntiD2ta this commit includes the refactoring of Lido contracts' deployed addresses

khalifaa55 avatar Aug 05 '24 15:08 khalifaa55