sedge icon indicating copy to clipboard operation
sedge copied to clipboard

Online Client versions

Open cbermudez97 opened this issue 2 years ago • 1 comments

Changes:

  • Allow Sedge to load latest supported clients versions when online.
  • Add new flag to reuse jwt secret when regenerating a Sedge setup.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [ ] Yes
  • [x] No

cbermudez97 avatar Jun 08 '23 20:06 cbermudez97

Codecov Report

Patch coverage: 45.51% and project coverage change: -2.68 :warning:

Comparison is base (847e2b9) 86.69% compared to head (1714a0c) 84.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
- Coverage    86.69%   84.02%   -2.68%     
===========================================
  Files           78       82       +4     
  Lines         4578     4833     +255     
===========================================
+ Hits          3969     4061      +92     
- Misses         523      686     +163     
  Partials        86       86              
Flag Coverage Δ
unittests 84.02% <45.51%> (-2.68%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/actions/update_clients.go 0.00% <0.00%> (ø)
configs/images/online_images.go 0.00% <0.00%> (ø)
configs/images/utils.go 25.53% <25.53%> (ø)
cli/generate.go 89.33% <60.00%> (-1.21%) :arrow_down:
cli/actions/actions.go 81.81% <75.00%> (+6.81%) :arrow_up:
cli/actions/importKeys.go 95.75% <100.00%> (+0.27%) :arrow_up:
cli/cli.go 68.64% <100.00%> (+0.78%) :arrow_up:
cli/sub_gen.go 95.81% <100.00%> (+0.05%) :arrow_up:
configs/images/default_images.go 100.00% <100.00%> (ø)
configs/images/images.go 100.00% <100.00%> (ø)
... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jun 08 '23 20:06 codecov-commenter