juno icon indicating copy to clipboard operation
juno copied to clipboard

Improve log messages

Open joshklop opened this issue 3 years ago • 1 comments

Description

Clarify logs by adjusting the level of some messages (mostly from Info -> Debug) and by editing the messages themselves.

Changes:

  • Adjust logs
  • Clarify messages

Types of changes

  • Refactoring

Testing

Requires testing: Manual testing

Did you write tests?: No

Documentation

If this requires a documentation update, did you add one? Once Juno stabilizes a bit more, it may be good to publish a blog post with a description of the log messages. I think it would be premature to publish such documentation now (p2p, sync refactor, and other changes will introduce different log messages than what we have now).

joshklop avatar Sep 06 '22 13:09 joshklop

Codecov Report

Merging #398 (c381281) into main (ee54e02) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head c381281 differs from pull request most recent head 22eb733. Consider uploading reports for the commit 22eb733 to get more accurate results

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          67       67           
  Lines        7214     7219    +5     
=======================================
+ Hits         6692     6697    +5     
  Misses        516      516           
  Partials        6        6           
Flag Coverage Δ
unittests 92.76% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/sync/apiCollection.go 100.00% <ø> (ø)
internal/sync/l1Collector.go 100.00% <ø> (ø)
internal/sync/sync.go 100.00% <ø> (ø)
pkg/felt/felt.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 06 '22 13:09 codecov[bot]