juno icon indicating copy to clipboard operation
juno copied to clipboard

Rianhughes/sequencer

Open rianhughes opened this issue 1 year ago • 3 comments

Merging https://github.com/NethermindEth/juno/compare/main...feature/sequencer into main, by cherry-picking

rianhughes avatar May 14 '24 08:05 rianhughes

Codecov Report

Attention: Patch coverage is 67.97900% with 244 lines in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (6e90f2e) to head (758f30b).

Files Patch % Lines
builder/builder.go 73.40% 43 Missing and 28 partials :warning:
genesis/genesis.go 62.26% 22 Missing and 18 partials :warning:
mempool/mempool.go 70.94% 19 Missing and 15 partials :warning:
blockchain/blockchain.go 70.23% 11 Missing and 14 partials :warning:
node/node.go 52.94% 18 Missing and 6 partials :warning:
node/genesis.go 0.00% 18 Missing :warning:
rpc/transaction.go 56.52% 6 Missing and 4 partials :warning:
blockchain/pending.go 78.04% 5 Missing and 4 partials :warning:
rpc/handlers.go 83.33% 2 Missing and 2 partials :warning:
utils/clone.go 42.85% 2 Missing and 2 partials :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   75.48%   75.08%   -0.41%     
==========================================
  Files          97      103       +6     
  Lines        8676     9354     +678     
==========================================
+ Hits         6549     7023     +474     
- Misses       1545     1663     +118     
- Partials      582      668      +86     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 14 '24 12:05 codecov[bot]

Note: Starknet updates the 0x1 contract after the 10th block (see here). This is the cause of the state-diff commitment change after the 10th block despite no incoming transactions, which will be the default behaviour for now (o/w modify MakeStateDiffForEmptyBlock)

rianhughes avatar May 20 '24 12:05 rianhughes

Note: the token contract should be updated to remove the assertions that the permissioned_minter can't be the zero address (when calling the token constructor blockifier, the sender address is the zero address - I currently get around this by passing the sender address into blockifier - which is a bit hacky).

rianhughes avatar Jul 03 '24 11:07 rianhughes