Rianhughes/sequencer
Merging https://github.com/NethermindEth/juno/compare/main...feature/sequencer into main, by cherry-picking
Codecov Report
Attention: Patch coverage is 67.97900% with 244 lines in your changes missing coverage. Please review.
Project coverage is 75.08%. Comparing base (
6e90f2e) to head (758f30b).
Additional details and impacted files
@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 75.48% 75.08% -0.41%
==========================================
Files 97 103 +6
Lines 8676 9354 +678
==========================================
+ Hits 6549 7023 +474
- Misses 1545 1663 +118
- Partials 582 668 +86
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note: Starknet updates the 0x1 contract after the 10th block (see here). This is the cause of the state-diff commitment change after the 10th block despite no incoming transactions, which will be the default behaviour for now (o/w modify MakeStateDiffForEmptyBlock)
Note: the token contract should be updated to remove the assertions that the permissioned_minter can't be the zero address (when calling the token constructor blockifier, the sender address is the zero address - I currently get around this by passing the sender address into blockifier - which is a bit hacky).