juno icon indicating copy to clipboard operation
juno copied to clipboard

Complete tests for `vm.Execute`

Open Lawliet-Chan opened this issue 2 years ago • 6 comments

As https://github.com/NethermindEth/juno/blob/main/vm/vm_test.go#L134, your test for vm.Execute() is filling nil transaction into it. I think we should add more tests with real cairo contracts to complete it. We make a test repo for this vm.Execute() https://github.com/reddio-com/testbot/tree/thix/add_declare BUT get some bug, could u pls tell me how to fix it?

You can build and test it with README. Then you will get the error as follows:

panic: invalid type: null, expected a sequence at line 1 column 4

goroutine 1 [running]:
main.main()
	/Users/lawliet/reddio/testbot/cairoVM/cmd/main.go:19 +0x91

Lawliet-Chan avatar Jan 18 '24 11:01 Lawliet-Chan

Can I be assigned to this?

PedroRosalba avatar Nov 03 '24 19:11 PedroRosalba

I’d love to work on this task.

josexx96 avatar Jan 10 '25 17:01 josexx96

Can I take care of this issue?

V15HNUPM avatar Jan 11 '25 05:01 V15HNUPM

Hi, I would like to take care of this issue since I already expressed interest in working on it. Please assign it to me.

josexx96 avatar Jan 11 '25 05:01 josexx96

Could I take over this issue?

chiscookeke11 avatar Jan 22 '25 16:01 chiscookeke11

Can I be assigned to this?

JuViquez avatar Feb 02 '25 20:02 JuViquez