StarknetByExample icon indicating copy to clipboard operation
StarknetByExample copied to clipboard

Account Abstraction - Spending Limits

Open egeaybars123 opened this issue 1 year ago • 3 comments

Issue(s): #230

Description

Account Contract with Spending Limits for any ERC20 token.

Checklist

  • [ ] CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • [x] Contract Tests: Added tests to cover the changes

egeaybars123 avatar Jul 22 '24 08:07 egeaybars123

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

julio4 avatar Aug 08 '24 04:08 julio4

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

Hey @julio4, I can work on those changes if you could please provide me with the feedback.

egeaybars123 avatar Aug 08 '24 07:08 egeaybars123

Hello @egeaybars123, do you want to continue working on this, or should I edit the last few changes by myself?

Hey @julio4, I can work on those changes if you could please provide me with the feedback.

My bad, I started a review and forgot to finish it. Let me finish it soon.

julio4 avatar Aug 08 '24 07:08 julio4

@egeaybars123 The repository has been upgraded to a new site generator and the Markdown format to include code listings is slightly different. The CONTRIBUTING guidelines has been updated to reflect these changes. Could you rebase this PR onto dev. If there's any issues or if you want me to do these changes let me know.

julio4 avatar Nov 20 '24 03:11 julio4

Hey @julio4, I am currently working on different things. I'd be really glad if you could make those changes! Have a great week.

egeaybars123 avatar Nov 20 '24 07:11 egeaybars123

I'll close this in favor of #277 Feel free to review it if needed

julio4 avatar Dec 12 '24 10:12 julio4