StarknetByExample icon indicating copy to clipboard operation
StarknetByExample copied to clipboard

Account Abstraction - Custom Validation Signature Scheme

Open OkoliEvans opened this issue 1 year ago • 7 comments

Issue(s): Close #191

Description

Please provide a brief description of the changes made in this pull request and how they address the related issue.

Checklist

  • [ ] CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
  • [ ] Contract Tests: Added tests to cover the changes

OkoliEvans avatar Jun 30 '24 11:06 OkoliEvans

@julio4 Pls check the adjustments I made, also the custom signature validation I used was the standard implementation for Secp256r1 and Secp256k1 used by Argent. Let me know what needs to be added or removed pls

OkoliEvans avatar Jul 16 '24 12:07 OkoliEvans

Made some adjustments based on your review @julio4

OkoliEvans avatar Jul 21 '24 12:07 OkoliEvans

Reviews implemented and pushed @julio4

OkoliEvans avatar Jul 24 '24 11:07 OkoliEvans

@julio4 Please check the adjustments and let me know what else to do

OkoliEvans avatar Aug 13 '24 20:08 OkoliEvans

@OkoliEvans The repository has been upgraded to a new site generator and the Markdown format to include code listings is slightly different. The CONTRIBUTING guidelines has been updated to reflect these changes. Could you rebase this PR onto dev. If there's any issues or if you want me to do these changes let me know.

julio4 avatar Nov 20 '24 03:11 julio4

@julio4 Alright, will get started on it

OkoliEvans avatar Nov 20 '24 22:11 OkoliEvans

@julio4 Adjustments have been completed and code upgraded to new Markdown format.

OkoliEvans avatar Nov 22 '24 11:11 OkoliEvans