maestro icon indicating copy to clipboard operation
maestro copied to clipboard

chore: remove Joda-Time dependency from maestro-common #25

Open pranaybattu opened this issue 1 year ago • 0 comments

Pull Request type

  • [ ] Bugfix
  • [ ] Feature
  • [x] Refactoring (no functional changes, no api changes)
  • [x] Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
  • [ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

This pull request removes the Joda-Time dependency #25 from the maestro-common module and replaces it with the java.time API. The changes include:

  • Removed Joda-Time dependency from the Defaults class and replaced it with java.time.ZoneId.
  • Updated TriggerHelper class to use java.time.ZoneId instead of Joda-Time's DateTimeZone.
  • Simplified TimeZoneValidator to use a static final set of available time zone IDs, ensuring efficient validation.

This change modernizes the codebase by adopting the java.time API, which is the recommended approach for handling date and time in Java 8 and later versions. The updates ensure that time zone handling is consistent and efficient

pranaybattu avatar Jul 25 '24 15:07 pranaybattu